fix(sdk): Disable OrderTracker for the moment#5407
Merged
Hywan merged 1 commit intomatrix-org:mainfrom Jul 15, 2025
Merged
Conversation
This patch removes the use of `OrderTracker` because the implementation of `EventCacheStore::load_all_chunks_metadata` for `SqliteEventCacheStore` is the cause of severe slownesses (up to 100s for some account). We are going to undo this patch once the problem has been solved.
Hywan
force-pushed
the
fix-sdk-event-cache-turn-off-order-tracker
branch
from
1a8862e to
6bbea2c
Compare
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #5407 +/- ##
==========================================
+ Coverage 88.80% 88.84% +0.03%
==========================================
Files 334 334
Lines 91256 91015 -241
Branches 91256 91015 -241
==========================================
- Hits 81044 80862 -182
+ Misses 6399 6340 -59
Partials 3813 3813 ☔ View full report in Codecov by Sentry. |
poljar
approved these changes
Jul 15, 2025
Contributor
poljar
left a comment
poljar
left a comment
There was a problem hiding this comment.
Alright, let's see if this is actually the culprit.
Member
Author
|
For the record, perf is no longer a problem. It confirms this is the culprit. Now let's fix that. |
This was referenced Jul 15, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch removes the use of
OrderTrackerbecause the implementation ofEventCacheStore::load_all_chunks_metadataforSqliteEventCacheStoreis the cause of severe slowness (up to 100s for some accounts). It's been introduced in #5225.We are going to undo this patch once the problem has been solved.
Edit:
SqliteEventCacheStore::load_all_chunks_metadataby 1140% #5411OrderTrackerfor the moment." #5412Metrics
Using this rageshake, the logs introduced in this PR, and this command-line to only list executions of
load_all_chunks_metadatataking more than one second: